lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Mar 2022 13:49:19 -0800 From: Yang Shi <shy828301@...il.com> To: Miaohe Lin <linmiaohe@...wei.com> Cc: Linux MM <linux-mm@...ck.org>, Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Vlastimil Babka <vbabka@...e.cz>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Song Liu <songliubraving@...com>, Rik van Riel <riel@...riel.com>, Matthew Wilcox <willy@...radead.org>, Zi Yan <ziy@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>, "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, darrick.wong@...cle.com Subject: Re: [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE On Tue, Mar 1, 2022 at 12:45 AM Miaohe Lin <linmiaohe@...wei.com> wrote: > > On 2022/3/1 7:57, Yang Shi wrote: > > MMF_VM_HUGEPAGE is set as long as the mm is available for khugepaged by > > khugepaged_enter(), not only when VM_HUGEPAGE is set on vma. Correct > > the comment to avoid confusion. > > > > Signed-off-by: Yang Shi <shy828301@...il.com> > > --- > > include/linux/sched/coredump.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > > index 4d9e3a656875..4d0a5be28b70 100644 > > --- a/include/linux/sched/coredump.h > > +++ b/include/linux/sched/coredump.h > > @@ -57,7 +57,8 @@ static inline int get_dumpable(struct mm_struct *mm) > > #endif > > /* leave room for more dump flags */ > > #define MMF_VM_MERGEABLE 16 /* KSM may merge identical pages */ > > -#define MMF_VM_HUGEPAGE 17 /* set when VM_HUGEPAGE is set on vma */ > > +#define MMF_VM_HUGEPAGE 17 /* set when mm is available for > > + khugepaged */ > > I think this comment could be written in one line. Anyway, this patch looks good to me. > Thanks. Yes, as long as we don't care about the 80 characters limit. I know the limit was bumped to 100 by checkpatch, but I have seen 80 was still preferred by a lot of people. > > Reviewed-by: Miaohe Lin <linmiaohe@...wei.com> Thanks. > > > /* > > * This one-shot flag is dropped due to necessity of changing exe once again > > * on NFS restore > > >
Powered by blists - more mailing lists