linux-ext4 - Re: [PATCH v2 1/5] ext4: convert i_fc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 15 Mar 2022 16:10:28 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     "harshadshirwadkar@...il.com" <harshadshirwadkar@...il.com>
CC:     "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "riteshh@...ux.ibm.com" <riteshh@...ux.ibm.com>,
        "jack@...e.cz" <jack@...e.cz>, "tytso@....edu" <tytso@....edu>,
        Daejun Park <daejun7.park@...sung.com>
Subject: Re: [PATCH v2 1/5] ext4: convert i_fc_lock to spinlock

Hi Harshad Shirwadkar,

...
>@@ -427,11 +427,11 @@ static int __track_dentry_update(struct inode *inode, void *arg, bool update)
> 	struct dentry *dentry = dentry_update->dentry;
> 	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
> 
>-	mutex_unlock(&ei->i_fc_lock);
>+	spin_unlock(&ei->i_fc_lock);
> 	node = kmem_cache_alloc(ext4_fc_dentry_cachep, GFP_NOFS);
Is it sleep-safe with spinlock?

> 	if (!node) {
> 		ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_NOMEM, NULL);
>-		mutex_lock(&ei->i_fc_lock);
>+		spin_lock(&ei->i_fc_lock);
> 		return -ENOMEM;
> 	}
> 

Thanks,
Daejun