lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue,  3 May 2022 00:02:45 -0400
From:   "Theodore Ts'o" <>
To:     Andreas Dilger <>
Cc:     "Theodore Ts'o" <>,
Subject: Re: [PATCH] e2fsck: no parent lookup in disconnected dir

On Sun, 12 Dec 2021 23:35:30 -0700, Andreas Dilger wrote:
> Don't call into ext2fs_get_pathname() to do a name lookup for a
> disconnected directory, since the directory block traversal in
> pass1 has already scanned all of the leaf blocks and never finds
> the entry, always printing "???".  If the name entry had been
> found earlier, the directory would not be disconnected in pass3.
> Instead, lookup ".." and print the parent name in the prompt, and
> then do not search for the current directory name at all.  This
> avoids a useless full directory scan for each disconnected entry,
> which can potentially be slow if the parent directory is large.
> [...]

Applied, thanks!

[1/1] e2fsck: no parent lookup in disconnected dir
      commit: 6b0e3bd7bd2f2db3c3993c5d91379ad55e60b51e

Best regards,
Theodore Ts'o <>

Powered by blists - more mailing lists