lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Aug 2022 09:31:21 +0800 From: zhanchengbin <zhanchengbin1@...wei.com> To: Theodore Ts'o <tytso@....edu> CC: <linux-ext4@...r.kernel.org>, linfeilong <linfeilong@...wei.com>, <liuzhiqiang26@...wei.com>, <liangyun2@...wei.com>, Alexey Lyahkov <alexey.lyashkov@...il.com> Subject: Re: [PATCH] tune2fs: do not change j_tail_sequence in journal superblock Friendly ping... On 2022/8/4 18:33, zhanchengbin wrote: > The function recover_ext3_journal in debugfs/journal.c, if the log > replay is over, > the j_tail_sequence in journal superblock is not changed to the value of > the last > transaction sequence, this will cause subsequent log commitids to count > from the > commitid in last time. > After tune2fs -e, the log commitid is counted from the commitid in last > time, if > the log ID of the current operation overlaps with that of the last > operation, this > will cause logs that were previously replayed by tune2fs to be replayed > here. > > Signed-off-by: zhanchengbin <zhanchengbin1@...wei.com> > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> > Signed-off-by: liangyun <liangyun2@...wei.com> > --- > debugfs/journal.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/debugfs/journal.c b/debugfs/journal.c > index 095fff00..5bac0d3b 100644 > --- a/debugfs/journal.c > +++ b/debugfs/journal.c > @@ -769,6 +769,8 @@ static errcode_t recover_ext3_journal(ext2_filsys fs) > mark_buffer_dirty(journal->j_sb_buffer); > } > > + journal->j_tail_sequence = journal->j_transaction_sequence; > + > errout: > jbd2_journal_destroy_revoke(journal); > jbd2_journal_destroy_revoke_record_cache();
Powered by blists - more mailing lists