linux-ext4 - Re: [PATCH] tune2fs: do not change j_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yvb6hPI1tinxoEgW@mit.edu>
Date:   Fri, 12 Aug 2022 21:12:36 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     zhanchengbin <zhanchengbin1@...wei.com>
Cc:     linux-ext4@...r.kernel.org, linfeilong <linfeilong@...wei.com>,
        liuzhiqiang26@...wei.com, liangyun2@...wei.com,
        Alexey Lyahkov <alexey.lyashkov@...il.com>
Subject: Re: [PATCH] tune2fs: do not change j_tail_sequence in journal
 superblock

On Thu, Aug 04, 2022 at 06:33:39PM +0800, zhanchengbin wrote:
> The function recover_ext3_journal in debugfs/journal.c, if the log replay is
> over,
> the j_tail_sequence in journal superblock is not changed to the value of the
> last
> transaction sequence, this will cause subsequent log commitids to count from
> the
> commitid in last time.
> After tune2fs -e, the log commitid is counted from the commitid in last
> time, if
> the log ID of the current operation overlaps with that of the last
> operation, this
> will cause logs that were previously replayed by tune2fs to be replayed
> here.
> 
> Signed-off-by: zhanchengbin <zhanchengbin1@...wei.com>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>
> Signed-off-by: liangyun <liangyun2@...wei.com>

Applied, thanks!

					- Ted