lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Aug 2022 10:32:35 -0400 From: "Theodore Ts'o" <tytso@....edu> To: krisman@...labora.com Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org, linux-ext4.vger.kernel.org@...anec.net Subject: Re: [PATCH] e2fsck: Always probe filesystem blocksize with simple io_manager On Mon, 25 Apr 2022 18:01:00 -0400, Gabriel Krisman Bertazi wrote: >Combining superblock (-b) with undo file (-z) fails iff the block size >is not specified (-B) and is different from the first blocksize probed >in try_open_fs (1k). The reason is as follows: > >try_open_fs() will probe different blocksizes if none is provided on >the command line. It is done by opening and closing the filesystem >until it finds a blocksize that makes sense. This is fine for all >io_managers, but undo_io creates the undo file with that blocksize >during ext2fs_open. Once try_open_fs realizes it had the wrong >blocksize and retries with a different blocksize, undo_io will read >the previously created file and think it's corrupt for this >filesystem. Applied, thanks! [1/1] e2fsck: Always probe filesystem blocksize with simple io_manager commit: 0ae0e93624a933a1c6ea4e4680ff5d609f267a43 Best regards, -- Theodore Ts'o <tytso@....edu>
Powered by blists - more mailing lists