lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Sep 2022 15:56:48 +0800 From: Jason Yan <yanaijie@...wei.com> To: Jan Kara <jack@...e.cz> CC: <tytso@....edu>, <adilger.kernel@...ger.ca>, <ritesh.list@...il.com>, <lczerner@...hat.com>, <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 08/13] ext4: factor out ext4_handle_csum() On 2022/8/31 19:52, Jan Kara wrote: > On Tue 30-08-22 20:04:06, Jason Yan wrote: >> Factor out ext4_handle_csum(). No functional change. >> >> Signed-off-by: Jason Yan <yanaijie@...wei.com> >> --- >> fs/ext4/super.c | 83 +++++++++++++++++++++++++++---------------------- >> 1 file changed, 46 insertions(+), 37 deletions(-) >> >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c >> index 9ee27472b802..96cf23787bba 100644 >> --- a/fs/ext4/super.c >> +++ b/fs/ext4/super.c >> @@ -4563,6 +4563,50 @@ static int ext4_encoding_init(struct super_block *sb, struct ext4_super_block *e >> return 0; >> } >> >> +static int ext4_handle_csum(struct super_block *sb, struct ext4_super_block *es) > > I'd rather call this function like ext4_init_metadata_csum(). > ext4_handle_csum() seems to vague to me. > Yes, much better. Thanks. > Otherwise the patch looks good to me. Feel free to add: > > Reviewed-by: Jan Kara <jack@...e.cz> > > Honza >
Powered by blists - more mailing lists