linux-ext4 - Re: [PATCH 09/13] ext4: factor out ext4_compat_feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed5fb099-cced-ad7e-aea3-6804e77cb67b@huawei.com>
Date:   Thu, 1 Sep 2022 15:58:11 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     <tytso@....edu>, <adilger.kernel@...ger.ca>,
        <ritesh.list@...il.com>, <lczerner@...hat.com>,
        <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 09/13] ext4: factor out ext4_compat_feature_check()


On 2022/8/31 19:55, Jan Kara wrote:
> On Tue 30-08-22 20:04:07, Jason Yan wrote:
>> Factor out ext4_compat_feature_check(). No functional change.
>>
>> Signed-off-by: Jason Yan<yanaijie@...wei.com>
>> ---
>>   fs/ext4/super.c | 144 ++++++++++++++++++++++++++----------------------
>>   1 file changed, 77 insertions(+), 67 deletions(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 96cf23787bba..1e7d6eb6a3aa 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -4607,6 +4607,82 @@ static int ext4_handle_csum(struct super_block *sb, struct ext4_super_block *es)
>>   	return 0;
>>   }
>>   
>> +static int ext4_compat_feature_check(struct super_block *sb,
>> +				     struct ext4_super_block *es,
>> +				     int silent)
> And here maybe ext4_check_feature_compatibility() might be a better name
> because "compat_feature" is a name of a specific subset of ext4 features so
> using it in function name is a bit confusing. Otherwise feel free to add:
> 

Indeed.

Thanks.

> Reviewed-by: Jan Kara<jack@...e.cz>