linux-ext4 - Re: [PATCH 13/13] ext4: factor out ext4_journal_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf93fb03-6765-a243-dddd-9fa0de273f8e@huawei.com>
Date:   Thu, 1 Sep 2022 15:59:02 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     <tytso@....edu>, <adilger.kernel@...ger.ca>,
        <ritesh.list@...il.com>, <lczerner@...hat.com>,
        <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 13/13] ext4: factor out ext4_journal_data_check()


On 2022/8/31 20:06, Jan Kara wrote:
> On Tue 30-08-22 20:04:11, Jason Yan wrote:
>> Factor out ext4_journal_data_check(). No functional change.
>>
>> Signed-off-by: Jason Yan<yanaijie@...wei.com>
>> ---
>>   fs/ext4/super.c | 60 ++++++++++++++++++++++++++++---------------------
>>   1 file changed, 35 insertions(+), 25 deletions(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 95e70f0316db..c070d4f5ecc4 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -4910,6 +4910,39 @@ static int ext4_load_and_init_journal(struct super_block *sb,
>>   	return err;
>>   }
>>   
>> +static int ext4_journal_data_check(struct super_block *sb)
> Perhaps name this ext4_journal_data_mode_check()? 

OK.

Thanks.

Otherwise feel free to
> add:
> 
> Reviewed-by: Jan Kara<jack@...e.cz>