linux-ext4 - Re: [PATCH v2 03/13] ext4: factor out ext4_set_def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5000fb7d-21ce-ed5c-a621-6f91dec527e0@huawei.com>
Date:   Mon, 12 Sep 2022 10:20:27 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     "Ritesh Harjani (IBM)" <ritesh.list@...il.com>
CC:     <tytso@....edu>, <adilger.kernel@...ger.ca>, <jack@...e.cz>,
        <lczerner@...hat.com>, <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v2 03/13] ext4: factor out ext4_set_def_opts()

Hi Ritesh, thanks for the review.

On 2022/9/8 16:44, Ritesh Harjani (IBM) wrote:
> On 22/09/03 11:01AM, Jason Yan wrote:
>> Factor out ext4_set_def_opts(). No functional change.
>         if (blocksize == PAGE_SIZE)
>                 set_opt(sb, DIOREAD_NOLOCK);
> The patch looks good however, even this ^^ could be moved in
> ext4_set_def_opts() via some refactoring.
> 
> If required you could even submit a seperate change for above.
> 

Yes, this needs some refactoring. I would like to make a separate patch 
in my next series.

Jason

> Otherwise this change looks good to me.
> Reviewed-by: Ritesh Harjani (IBM)<ritesh.list@...il.com>
> 
>