lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Sep 2022 10:30:14 +0800 From: Jason Yan <yanaijie@...wei.com> To: "Ritesh Harjani (IBM)" <ritesh.list@...il.com> CC: <tytso@....edu>, <adilger.kernel@...ger.ca>, <jack@...e.cz>, <lczerner@...hat.com>, <linux-ext4@...r.kernel.org> Subject: Re: [PATCH v2 07/13] ext4: factor out ext4_encoding_init() On 2022/9/8 16:56, Ritesh Harjani (IBM) wrote: > On 22/09/03 11:01AM, Jason Yan wrote: >> Factor out ext4_encoding_init(). No functional change. >> >> Signed-off-by: Jason Yan <yanaijie@...wei.com> >> Reviewed-by: Jan Kara <jack@...e.cz> >> --- >> fs/ext4/super.c | 80 +++++++++++++++++++++++++++---------------------- >> 1 file changed, 44 insertions(+), 36 deletions(-) >> >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c >> index f8806226b796..67972b0218c0 100644 >> --- a/fs/ext4/super.c >> +++ b/fs/ext4/super.c >> @@ -4521,6 +4521,48 @@ static int ext4_inode_info_init(struct super_block *sb, >> return 0; >> } >> >> +static int ext4_encoding_init(struct super_block *sb, struct ext4_super_block *es) >> +{ >> +#if IS_ENABLED(CONFIG_UNICODE) > > How about simplying it like below. > if (!IS_ENABLED(CONFIG_UNICODE)) > return 0; > > <...> > > Then we don't need #ifdef CONFIG_UNICODE > Nice idea. Will update. Thanks Jason
Powered by blists - more mailing lists