linux-ext4 - Re: [PATCH] debugfs:fix repeated output problem with `logdump -O -n <num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2023 16:38:43 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     "lihaoxiang (F)" <lihaoxiang9@...wei.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Zhiqiang Liu <liuzhiqiang26@...wei.com>,
        linux-ext4@...r.kernel.org, linfeilong@...wei.com,
        louhongxiang@...wei.com
Subject: Re: [PATCH] debugfs:fix repeated output problem with `logdump -O -n <num_trans>`

On Tue, 15 Nov 2022 16:29:55 +0800, lihaoxiang (F) wrote:
> Previously, patch 6e4cc3d5eeb2dfaa055e652b5390beaa6c3d05da introduces
> the function of printing the specified number of logs. But there exists
> a shortage when n is larger than the total number of logs, it dumped the
> duplicated records circulately.
> 
> For example, the disk sda only has three records, but using instruction logdump
> -On5, it would output the result as follow:
> ----------------------------------------------------------------------
> Journal starts at block 1, transaction 6
> Found expected sequence 6, type 1 (descriptor block) at block 1
> Found expected sequence 6, type 2 (commit block) at block 4
> No magic number at block 5: end of journal.
> Found sequence 2 (not 7) at block 7: end of journal.
> Found expected sequence 2, type 2 (commit block) at block 7
> Found sequence 3 (not 8) at block 8: end of journal.
> Found expected sequence 3, type 1 (descriptor block) at block 8
> Found sequence 3 (not 8) at block 15: end of journal.
> Found expected sequence 3, type 2 (commit block) at block 15
> Found sequence 6 (not 9) at block 1: end of journal.       <---------begin loop
> Found expected sequence 6, type 1 (descriptor block) at block 1
> Found sequence 6 (not 9) at block 4: end of journal.
> Found expected sequence 6, type 2 (commit block) at block 4
> Found sequence 2 (not 10) at block 7: end of journal.
> Found expected sequence 2, type 2 (commit block) at block 7
> logdump: short read (read 0, expected 1024) while reading journal
> 
> [...]

Applied, thanks!

[1/1] debugfs:fix repeated output problem with `logdump -O -n <num_trans>`
      commit: 9562cfca93da6d70494c3a66bddbc9d439410a34

Best regards,
-- 
Theodore Ts'o <tytso@....edu>