linux-ext4 - Re: [PATCH v2] lib/ext2fs: add some msg for io error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/gzOSmW70rXcjvq@mit.edu>
Date:   Thu, 23 Feb 2023 22:47:05 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     zhanchengbin <zhanchengbin1@...wei.com>
Cc:     linux-ext4@...r.kernel.org, linfeilong@...wei.com,
        louhongxiang@...wei.com
Subject: Re: [PATCH v2] lib/ext2fs: add some msg for io error

On Thu, Feb 23, 2023 at 05:01:11PM +0800, zhanchengbin wrote:
> Add msgs to show whether there is eio in fsck process, when write and
> fsync methods fail.
> 
> Signed-off-by: zhanchengbin <zhanchengbin1@...wei.com>

The libext2fs is a *library*.  As such, well designed libraries do not
randomly write to stderr.  Consider what might happen if there was a
curses based program that was calling libext2fs --- for example, like
the ext2ed program.  Writing random errors to stderr is just *rude*.   :-)

If what you're worried about errors from e2fsck, it's also not
necessary, since that's what the error handler callback is for.

Cheers,

					- Ted