linux-ext4 - Re: [PATCH v2] lib/ext2fs: add some msg for io error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae16157c-48fd-84c8-9fe5-8645395cefa6@huawei.com>
Date:   Fri, 24 Feb 2023 15:38:57 +0800
From:   zhanchengbin <zhanchengbin1@...wei.com>
To:     Theodore Ts'o <tytso@....edu>
CC:     <linux-ext4@...r.kernel.org>, <linfeilong@...wei.com>,
        <louhongxiang@...wei.com>
Subject: Re: [PATCH v2] lib/ext2fs: add some msg for io error

The e2fsck_handle_write_error is called only unix_write_blk64 and
unix_read_blk64 failed, but there is no failure message in unix_write_byte
and unix_flush.

Thanks,
  - bin.

On 2023/2/24 11:47, Theodore Ts'o wrote:
> On Thu, Feb 23, 2023 at 05:01:11PM +0800, zhanchengbin wrote:
>> Add msgs to show whether there is eio in fsck process, when write and
>> fsync methods fail.
>>
>> Signed-off-by: zhanchengbin <zhanchengbin1@...wei.com>
> 
> The libext2fs is a *library*.  As such, well designed libraries do not
> randomly write to stderr.  Consider what might happen if there was a
> curses based program that was calling libext2fs --- for example, like
> the ext2ed program.  Writing random errors to stderr is just *rude*.   :-)
> 
> If what you're worried about errors from e2fsck, it's also not
> necessary, since that's what the error handler callback is for.
> 
> Cheers,
> 
> 					- Ted
> .
>