linux-ext4 - Re: [PATCH v2 2/5] ext4: No need to check return value of block_commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e30082535f1d7e92692718f1d25a08508f04fe0a.camel@gmail.com>
Date:   Tue, 20 Jun 2023 12:59:42 +0200
From:   Bean Huo <huobean@...il.com>
To:     Christoph Hellwig <hch@...radead.org>, Bean Huo <beanhuo@...pp.de>
Cc:     viro@...iv.linux.org.uk, brauner@...nel.org,
        akpm@...ux-foundation.org, jack@...e.cz, jack@...e.com,
        tytso@....edu, adilger.kernel@...ger.ca, mark@...heh.com,
        jlbec@...lplan.org, joseph.qi@...ux.alibaba.com,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, ocfs2-devel@....oracle.com,
        beanhuo@...ron.com
Subject: Re: [PATCH v2 2/5] ext4: No need to check return value of
 block_commit_write()

On Mon, 2023-06-19 at 21:48 -0700, Christoph Hellwig wrote:
> On Mon, Jun 19, 2023 at 11:18:24PM +0200, Bean Huo wrote:
> > From: Bean Huo <beanhuo@...ron.com>
> > 
> > Remove unnecessary check on the return value of
> > block_commit_write(),
> > because it always returns 0.
> 
> Dropping the error check before the function signature is changes is
> really odd.  I'd suggest to merge this and the following patches into
> a single one.

No problem, I will merge them together, thanks.

Kind regards,
Bean