lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240102130240.to4hnuuheo72nbt3@quack3> Date: Tue, 2 Jan 2024 14:02:40 +0100 From: Jan Kara <jack@...e.cz> To: Kemeng Shi <shikemeng@...weicloud.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/8] ext4: remove unneeded return value of ext4_mb_release_context On Sun 26-11-23 00:11:38, Kemeng Shi wrote: > Function ext4_mb_release_context always return 0 and the return value is > never used. Just remove unneeded return value of ext4_mb_release_context. > > Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/mballoc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 765b62729..f79e87ad3 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -5939,7 +5939,7 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac) > /* > * release all resource we used in allocation > */ > -static int ext4_mb_release_context(struct ext4_allocation_context *ac) > +static void ext4_mb_release_context(struct ext4_allocation_context *ac) > { > struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); > struct ext4_prealloc_space *pa = ac->ac_pa; > @@ -5976,7 +5976,6 @@ static int ext4_mb_release_context(struct ext4_allocation_context *ac) > if (ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC) > mutex_unlock(&ac->ac_lg->lg_mutex); > ext4_mb_collect_stats(ac); > - return 0; > } > > static int ext4_mb_discard_preallocations(struct super_block *sb, int needed) > -- > 2.30.0 > > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists