linux-ext4 - [PATCH] ext4: return error on syncfs after shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240904084657.1062243-1-amir73il@gmail.com>
Date: Wed,  4 Sep 2024 10:46:57 +0200
From: Amir Goldstein <amir73il@...il.com>
To: Theodore Tso <tytso@....edu>
Cc: "Darrick J . Wong" <djwong@...nel.org>,
	Jan Kara <jack@...e.cz>,
	Zorro Lang <zlang@...nel.org>,
	linux-ext4@...r.kernel.org,
	fstests@...r.kernel.org
Subject: [PATCH] ext4: return error on syncfs after shutdown

This is the logic behavior and one that we would like to verify
using a generic fstest similar to xfs/546.

Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
Suggested-by: Darrick J. Wong <djwong@...nel.org>
Signed-off-by: Amir Goldstein <amir73il@...il.com>
---

Ted,

Please see the discussion about moving test xfs/546 to generic.

WDYT?

Thanks,
Amir.

 fs/ext4/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e72145c4ae5a..b9cf18819e11 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
 
 	if (unlikely(ext4_forced_shutdown(sb)))
-		return 0;
+		return -EIO;
 
 	trace_ext4_sync_fs(sb, wait);
 	flush_workqueue(sbi->rsv_conversion_wq);
-- 
2.34.1