[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87tt74vbyz.fsf@gmail.com>
Date: Fri, 04 Apr 2025 09:01:48 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>, fstests@...r.kernel.org
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, ojaswin@...ux.ibm.com, djwong@...nel.org, zlang@...nel.org, david@...morbit.com, nirjhar.roy.lists@...il.com
Subject: Re: [PATCH v2 1/5] generic/749: Remove redundant sourcing of common/rc
"Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com> writes:
> common/rc is already sourced before the test starts running
> in _begin_fstest() preamble.
Indeed. The patch looks good to me.
Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@...il.com>
> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>
> ---
> tests/generic/749 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/749 b/tests/generic/749
> index fc747738..451f283e 100755
> --- a/tests/generic/749
> +++ b/tests/generic/749
> @@ -15,7 +15,6 @@
> # boundary and ensures we get a SIGBUS if we write to data beyond the system
> # page size even if the block size is greater than the system page size.
> . ./common/preamble
> -. ./common/rc
> _begin_fstest auto quick prealloc
>
> # Import common functions.
> --
> 2.34.1
Powered by blists - more mailing lists