linux-ext4 - [PATCH] common/rc: fix dumping of corrupt ext* filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407235931.GB6274@frogsfrogsfrogs>
Date: Mon, 7 Apr 2025 16:59:31 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Zorro Lang <zlang@...hat.com>
Cc: fstests <fstests@...r.kernel.org>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: [PATCH] common/rc: fix dumping of corrupt ext* filesystems

From: Darrick J. Wong <djwong@...nel.org>

The parameters to _ext4_metadump are device, dumpfile, and compress
options.  This callsite got the arguments in the wrong order, which
causes fstests to compress all of /dev/sdX as /dev/sdX.zst which is not
what we want.

Cc: <fstests@...r.kernel.org> # v2022.05.01
Fixes: 9fb30a9500c169 ("common: capture qcow2 dumps of corrupt ext* filesystems")
Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
---
 common/rc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index b2155d37a90d68..a71c15986efd18 100644
--- a/common/rc
+++ b/common/rc
@@ -3552,7 +3552,7 @@ _check_generic_filesystem()
         case "$FSTYP" in
         ext*)
             local flatdev="$(basename "$device")"
-            _ext4_metadump "$seqres.$flatdev.check.qcow2" "$device" compress
+            _ext4_metadump "$device" "$seqres.$flatdev.check.qcow2" compress
             ;;
         esac
     fi