linux-ext4 - Re: [PATCH] common/rc: fix dumping of corrupt ext* filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250408195205.zelfuglmamb5w3ft@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
Date: Wed, 9 Apr 2025 03:52:05 +0800
From: Zorro Lang <zlang@...hat.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: fstests <fstests@...r.kernel.org>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] common/rc: fix dumping of corrupt ext* filesystems

On Mon, Apr 07, 2025 at 04:59:31PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@...nel.org>
> 
> The parameters to _ext4_metadump are device, dumpfile, and compress
> options.  This callsite got the arguments in the wrong order, which
> causes fstests to compress all of /dev/sdX as /dev/sdX.zst which is not
> what we want.
> 
> Cc: <fstests@...r.kernel.org> # v2022.05.01
> Fixes: 9fb30a9500c169 ("common: capture qcow2 dumps of corrupt ext* filesystems")
> Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
> ---

Reviewed-by: Zorro Lang <zlang@...hat.com>

>  common/rc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index b2155d37a90d68..a71c15986efd18 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3552,7 +3552,7 @@ _check_generic_filesystem()
>          case "$FSTYP" in
>          ext*)
>              local flatdev="$(basename "$device")"
> -            _ext4_metadump "$seqres.$flatdev.check.qcow2" "$device" compress
> +            _ext4_metadump "$device" "$seqres.$flatdev.check.qcow2" compress
>              ;;
>          esac
>      fi
>