linux-ext4 - Re: [PATCH v5 1/1] xfs: Fail remount with noattr2 on a v5 with v4 enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <796c228b-a072-498d-819a-c09b2708ac0a@gmail.com>
Date: Mon, 12 May 2025 21:59:15 +0530
From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org,
 fstests@...r.kernel.org, ritesh.list@...il.com, ojaswin@...ux.ibm.com,
 djwong@...nel.org, zlang@...nel.org, david@...morbit.com, cem@...nel.org
Subject: Re: [PATCH v5 1/1] xfs: Fail remount with noattr2 on a v5 with v4
 enabled


On 5/12/25 21:06, Christoph Hellwig wrote:
> This still looks good.
Thanks.
>
> One nit:
>
>> +	/*
>> +	 * Now that mp has been modified according to the remount options,
>> +	 * we do a final option validation with xfs_finish_flags()
>> +	 * just like it is done during mount. We cannot use
>> +	 * xfs_finish_flags()on new_mp as it contains only the user
>> +	 * given options.
> This could use slightly better formatting:
>
> 	/*
> 	 * Now that mp has been modified according to the remount options, we
> 	 * do a final option validation with xfs_finish_flags() just like it is
> 	 * done during mount. We cannot use xfs_finish_flags() on new_mp as it
> 	 * contains only the user given options.
> 	 */

Okay, I will make the change in the next revision.

--NR

-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore