linux-ext4 - Re: [PATCH v2 1/2] new: Add a new parameter (name/emailid) in the "new" script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz6gvto1.fsf@gmail.com>
Date: Sat, 17 May 2025 08:18:46 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>, fstests@...r.kernel.org
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, ojaswin@...ux.ibm.com, djwong@...nel.org, zlang@...nel.org, david@...morbit.com, nirjhar.roy.lists@...il.com
Subject: Re: [PATCH v2 1/2] new: Add a new parameter (name/emailid) in the "new" script

"Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com> writes:

> This patch another optional interactive prompt to enter the
> author name and email id for each new test file that is
> created using the "new" file.
>
> The sample output looks like something like the following:
>
> ./new selftest
> Next test id is 007
> Append a name to the ID? Test name will be 007-$name. y,[n]:
> Creating test file '007'
> Add to group(s) [auto] (separate by space, ? for list): selftest quick
> Enter <author_name> <email-id>: Nirjhar Roy <nirjhar.roy.lists@...il.com>

I don't see much of a value add in this change here, as folks or
atleast I prefer to quickly get into writing my test first and later
worry about these details :). But I guess I understand where you are
coming from, a lot of times people miss to update this and end up
sending a test with "YOUR NAME HERE" placeholder.

So, sure if we are doing this - then please fix the commit message too,
as it still shows <email-id> above.

-ritesh

> Creating skeletal script for you to edit ...
>  done.
>
> ...
> ...
>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@...il.com>
> ---
>  new | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/new b/new
> index 6b50ffed..636648e2 100755
> --- a/new
> +++ b/new
> @@ -136,6 +136,9 @@ else
>  	check_groups "${new_groups[@]}" || exit 1
>  fi
>  
> +read -p "Enter <author_name>: " -r
> +author_name="${REPLY:=YOUR NAME HERE}"
> +
>  echo -n "Creating skeletal script for you to edit ..."
>  
>  year=`date +%Y`
> @@ -143,7 +146,7 @@ year=`date +%Y`
>  cat <<End-of-File >$tdir/$id
>  #! /bin/bash
>  # SPDX-License-Identifier: GPL-2.0
> -# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
> +# Copyright (c) $year $author_name.  All Rights Reserved.
>  #
>  # FS QA Test $id
>  #
> -- 
> 2.34.1