[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87cyc7wzg1.fsf@gmail.com>
Date: Sat, 17 May 2025 11:28:38 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>, fstests@...r.kernel.org
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, ojaswin@...ux.ibm.com, djwong@...nel.org, zlang@...nel.org, david@...morbit.com, nirjhar.roy.lists@...il.com
Subject: Re: [PATCH v2 2/2] new: Replace "status=0; exit 0" with _exit 0
"Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com> writes:
> We should now start using _exit 0 for every new test
> that we add.
>
Right every test now sources common/exit in _begin_test() preamble.
So we may as well start using _exit for new tests.
Looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@...il.com>
> Reviewed-by: Zorro Lang <zlang@...hat.com>
> ---
> new | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/new b/new
> index 636648e2..dff69265 100755
> --- a/new
> +++ b/new
> @@ -176,8 +176,7 @@ exit
> #echo "If failure, check \$seqres.full (this) and \$seqres.full.ok (reference)"
>
> # success, all done
> -status=0
> -exit
> +_exit 0
> End-of-File
>
> sleep 2 # latency to read messages to this point
> --
> 2.34.1
Powered by blists - more mailing lists