linux-ext4 - Re: [PATCH v3 1/2] new: Add a new parameter (name) in the "new" script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c95fc356-d7e5-4a0a-9e0f-8581893da189@gmail.com>
Date: Sat, 24 May 2025 00:36:46 +0530
From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>
To: Zorro Lang <zlang@...hat.com>
Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org,
 linux-xfs@...r.kernel.org, ritesh.list@...il.com, ojaswin@...ux.ibm.com,
 djwong@...nel.org, zlang@...nel.org, david@...morbit.com
Subject: Re: [PATCH v3 1/2] new: Add a new parameter (name) in the "new"
 script


On 5/23/25 19:42, Zorro Lang wrote:
> On Fri, May 23, 2025 at 10:03:43PM +0800, Zorro Lang wrote:
>> On Mon, May 19, 2025 at 06:16:41AM +0000, Nirjhar Roy (IBM) wrote:
>>> This patch another optional interactive prompt to enter the
>>> author name for each new test file that is created using
>>> the "new" file.
>>>
>>> The sample output looks like something like the following:
>>>
>>> ./new selftest
>>> Next test id is 007
>>> Append a name to the ID? Test name will be 007-$name. y,[n]:
>>> Creating test file '007'
>>> Add to group(s) [auto] (separate by space, ? for list): selftest quick
>>> Enter <author_name>: Nirjhar Roy <nirjhar.roy.lists@...il.com>
>>> Creating skeletal script for you to edit ...
>>>   done.
>>>
>>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@...il.com>
>>> ---
>>>   new | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/new b/new
>>> index 6b50ffed..636648e2 100755
>>> --- a/new
>>> +++ b/new
>>> @@ -136,6 +136,9 @@ else
>>>   	check_groups "${new_groups[@]}" || exit 1
>>>   fi
>>>   
>>> +read -p "Enter <author_name>: " -r
>>> +author_name="${REPLY:=YOUR NAME HERE}"
>>> +
>>>   echo -n "Creating skeletal script for you to edit ..."
>>>   
>>>   year=`date +%Y`
>>> @@ -143,7 +146,7 @@ year=`date +%Y`
>>>   cat <<End-of-File >$tdir/$id
>>>   #! /bin/bash
>>>   # SPDX-License-Identifier: GPL-2.0
>>> -# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
>>> +# Copyright (c) $year $author_name.  All Rights Reserved.
>> Dave thought we shouldn't use "author_name" at here:
>> https://lore.kernel.org/fstests/aC509xXxgZJKKZVE@dread.disaster.area/
>>
>> If you don't mind, I'll merge PATCH 2/2 this week. If you still hope to
>> have the 1/2, please consider the review point from Dave.
> Oh, sorry, you've sent a V4... Please ignore this one, I'm going to review
> your V4.

Yes, I have sent the v4 after addressing the review comments.

--NR

>
>> Thanks,
>> Zorro
>>
>>>   #
>>>   # FS QA Test $id
>>>   #
>>> -- 
>>> 2.34.1
>>>
>>>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore