linux-ext4 - Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250910145241.GA3662537@mit.edu>
Date: Wed, 10 Sep 2025 10:52:41 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Ralph Siemsen <ralph.siemsen@...aro.org>
Cc: Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

On Tue, Sep 09, 2025 at 08:49:37PM -0400, Ralph Siemsen wrote:
> Hi Andreas,
> 
> On Tue, Sep 9, 2025 at 8:32 PM Andreas Dilger <adilger@...ger.ca> wrote:
> >
> > I think it would be much better to allow and merge multiple "-E" options.
> 
> Agreed. I'll work on it and post a v2 patch.

What I would suggest that you do is to move code which mutates the
file system from parse_extended_opts() so it is only interpreting the
options, and move that code to tuine2fs_main().

That way we can call parse_extended_opts() multiple times.  In fact,
that had been on my todo list, since I need to do this to support
changing the superblock using ioctl's while it is mounted, so we can
deny read/write access to the block device while the file system is
mounted.  See [1].

[1] https://lore.kernel.org/all/20250908-tune2fs-v1-0-e3a6929f3355@mit.edu/

Cheers,

						- Ted