linux-ext4 - Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250910150028.GB3662537@mit.edu>
Date: Wed, 10 Sep 2025 11:00:28 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Ralph Siemsen <ralph.siemsen@...aro.org>
Cc: Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

On Wed, Sep 10, 2025 at 10:52:41AM -0400, Theodore Ts'o wrote:
> What I would suggest that you do is to move code which mutates the
> file system from parse_extended_opts() so it is only interpreting the
> options, and move that code to tuine2fs_main().
> 
> That way we can call parse_extended_opts() multiple times.  In fact,
> that had been on my todo list, since I need to do this to support
> changing the superblock using ioctl's while it is mounted, so we can
> deny read/write access to the block device while the file system is
> mounted.  See [1].
> 
> [1] https://lore.kernel.org/all/20250908-tune2fs-v1-0-e3a6929f3355@mit.edu/

In fact, if you want to see the direction which I'm headed, here is a
purely in-progress patch set for tune2fs.  The first patch is
incomplete because it doesn't handle parse_extended_opts() yet.

Since I want to have two code paths for setting the file system
parameters (one when the file system is mounted, one when it is
unmounted), it's why I want to separate out the functionality in
parse_extended_opts().

      	      	       	       		     - Ted

View attachment "0001-tune2fs-reorganize-command-line-flag-handling.patch" of type "text/x-diff" (16795 bytes)

View attachment "0002-DO-NOT-SUBMIT-tune2fs-initial-support-for-EXT4_IOC_G.patch" of type "text/x-diff" (8044 bytes)