linux-ext4 - Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANp-EDZ-5_UC+p77d+ZPMMtbH3eXAPvoL4tR_EL3dcpBk-wKeQ@mail.gmail.com>
Date: Wed, 10 Sep 2025 12:29:21 -0400
From: Ralph Siemsen <ralph.siemsen@...aro.org>
To: "Theodore Ts'o" <tytso@....edu>
Cc: Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

Hi Ted,

On Wed, Sep 10, 2025 at 10:52 AM Theodore Ts'o <tytso@....edu> wrote:
> What I would suggest that you do is to move code which mutates the
> file system from parse_extended_opts() so it is only interpreting the
> options, and move that code to tuine2fs_main().

Yes, I see where you are going. Being able to deny read/write to a
block device that is mounted is a good goal.

But I am talking about mke2fs rather than tune2fs. I can't really see
a need for two code paths when creating a filesystem?

It would still make sense to separate the option parsing from the
mutation logic of course.

> That way we can call parse_extended_opts() multiple times.

Note this is already occurs in mke2fs: one call to process options
from profile/config file, and another call for command-line args.

So in v2 patch, I just made further calls, one for each -E argument.
So far it seems to work without problems.

Regards
-Ralph