linux-ext4 - Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250910204543.GA3659556@mit.edu>
Date: Wed, 10 Sep 2025 16:45:43 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Ralph Siemsen <ralph.siemsen@...aro.org>
Cc: Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

On Wed, Sep 10, 2025 at 12:29:21PM -0400, Ralph Siemsen wrote:
> > That way we can call parse_extended_opts() multiple times.
> 
> Note this is already occurs in mke2fs: one call to process options
> from profile/config file, and another call for command-line args.

Sorry, I've had tune2fs on the brain.  Mke2fs is different from
tune2fs because there's only one path for configuring the newly create
file system --- and we have to process the command-line extended
options *after* processing the profile/config file options.

So in PRS, we need to save each of the -E arguments --- or concatenate
them together into a single set of extended options, and keep the call
site for parse_extended_options() them where it currently is located

						- Ted