linux-ext4 - Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANp-EDYrY0W6LE_1kc0NvhyOS65UW4znYZ_suFUQO+zxvQDA=Q@mail.gmail.com>
Date: Fri, 19 Sep 2025 11:44:17 -0400
From: Ralph Siemsen <ralph.siemsen@...aro.org>
To: "Theodore Ts'o" <tytso@....edu>
Cc: Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

Hi Andreas and Ted,

On Wed, Sep 10, 2025 at 5:31 PM Ralph Siemsen <ralph.siemsen@...aro.org> wrote:
> On Wed, Sep 10, 2025 at 4:45 PM Theodore Ts'o <tytso@....edu> wrote:
>
> > So in PRS, we need to save each of the -E arguments --- or concatenate
> > them together into a single set of extended options, and keep the call
> > site for parse_extended_options() them where it currently is located
>
> That what I am doing in patch v2:
> https://lore.kernel.org/linux-ext4/20250910-mke2fs-small-fixes-v2-2-55c9842494e0@linaro.org/T/#u
> It makes use of the already existing push_string() helper, to make
> copies of each argument.

Any feedback on the v2 patch series [1]? If you prefer another
approach (such as concatenating extended options) please let me know.

Also any comments regarding the other changes, particularly the
addition of root_selinux extended option?

[1] https://lore.kernel.org/linux-ext4/20250910-mke2fs-small-fixes-v2-0-55c9842494e0@linaro.org/

Thanks,
-Ralph