linux-ext4 - Re: [PATCH 2/2] ext4: improve integrity checking in __mb_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251125214739.GA59583@mac.lan>
Date: Tue, 25 Nov 2025 15:47:39 -0600
From: "Theodore Tso" <tytso@....edu>
To: Sun Yongjian <sunyongjian1@...wei.com>
Cc: Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, yangerkun@...wei.com,
        yi.zhang@...wei.com, libaokun1@...wei.com, chengzhihao1@...wei.com
Subject: Re: [PATCH 2/2] ext4: improve integrity checking in __mb_check_buddy
 by enhancing order-0 validation

On Thu, Nov 06, 2025 at 10:59:22AM +0800, Sun Yongjian wrote:
> 
> Thanks a lot for pointing out the logical flaw! Yes, you’re right—if order-0
> bit pair is clear, then without a single 0 showing up at any higher order
> we’ll never enter the `if` branch to run `MB_CHECK_ASSERT`. The code you
> proposed is indeed a better, more elegant implementation!

Were you planning on sending a revised version of this patch set with
the suggested change?

Thanks,

						- Ted