linux-ext4 - Re: [PATCH 2/2] ext4: improve integrity checking in __mb_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ebbd365-702c-4491-86c6-23c6242ba80d@huawei.com>
Date: Wed, 26 Nov 2025 17:12:49 +0800
From: Sun Yongjian <sunyongjian1@...wei.com>
To: Theodore Tso <tytso@....edu>
CC: Jan Kara <jack@...e.cz>, <linux-ext4@...r.kernel.org>,
	<linux-fsdevel@...r.kernel.org>, <yangerkun@...wei.com>,
	<yi.zhang@...wei.com>, <libaokun1@...wei.com>, <chengzhihao1@...wei.com>
Subject: Re: [PATCH 2/2] ext4: improve integrity checking in __mb_check_buddy
 by enhancing order-0 validation



在 2025/11/26 5:47, Theodore Tso 写道:
> On Thu, Nov 06, 2025 at 10:59:22AM +0800, Sun Yongjian wrote:
>>
>> Thanks a lot for pointing out the logical flaw! Yes, you’re right—if order-0
>> bit pair is clear, then without a single 0 showing up at any higher order
>> we’ll never enter the `if` branch to run `MB_CHECK_ASSERT`. The code you
>> proposed is indeed a better, more elegant implementation!
> 
> Were you planning on sending a revised version of this patch set with
> the suggested change?
> 
> Thanks,
> 
> 						- Ted
> 

Hi Ted!

Thank you for the reminder. Yes, I've already sent the revised version 
with the suggested changes, you might have missed this email 🙂

https://lore.kernel.org/all/20251106060614.631382-1-sunyongjian@huaweicloud.com/

Cheers,
Yongjian