linux-ext4 - Re: [PATCH] ext4: fix iloc.bh leak in ext4_xattr_inode_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34bce2ba-dbee-453c-a456-838cef094d50@huaweicloud.com>
Date: Sat, 13 Dec 2025 15:45:10 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Yang Erkun <yangerkun@...wei.com>
Cc: libaokun1@...wei.com, yangerkun@...weicloud.com, tytso@....edu,
 adilger.kernel@...ger.ca, eraykrdg1@...il.com,
 albinbabuvarghese20@...il.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix iloc.bh leak in ext4_xattr_inode_update_ref

On 12/13/2025 1:57 PM, Yang Erkun wrote:
> The error branch for ext4_xattr_inode_update_ref forget to release the
> refcount for iloc.bh. Find this when review code.
> 
> Fixes: 57295e835408 ("ext4: guard against EA inode refcount underflow in xattr update")
> Signed-off-by: Yang Erkun <yangerkun@...wei.com>

Looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>  fs/ext4/xattr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 2e02efbddaac..4ed8ddf2a60b 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1037,6 +1037,7 @@ static int ext4_xattr_inode_update_ref(handle_t *handle, struct inode *ea_inode,
>  		ext4_error_inode(ea_inode, __func__, __LINE__, 0,
>  			"EA inode %lu ref wraparound: ref_count=%lld ref_change=%d",
>  			ea_inode->i_ino, ref_count, ref_change);
> +		brelse(iloc.bh);
>  		ret = -EFSCORRUPTED;
>  		goto out;
>  	}