linux-ext4 - Re: [PATCH] ext4: fix iloc.bh leak in ext4_xattr_inode_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3631525a-1df6-47a4-b0b8-f20ab137264d@huawei.com>
Date: Mon, 15 Dec 2025 10:02:37 +0800
From: Baokun Li <libaokun1@...wei.com>
To: Yang Erkun <yangerkun@...wei.com>
CC: <tytso@....edu>, <adilger.kernel@...ger.ca>, <eraykrdg1@...il.com>,
	<albinbabuvarghese20@...il.com>, <linux-ext4@...r.kernel.org>,
	<yi.zhang@...wei.com>, <yangerkun@...weicloud.com>
Subject: Re: [PATCH] ext4: fix iloc.bh leak in ext4_xattr_inode_update_ref

On 2025-12-13 13:57, Yang Erkun wrote:
> The error branch for ext4_xattr_inode_update_ref forget to release the
> refcount for iloc.bh. Find this when review code.
>
> Fixes: 57295e835408 ("ext4: guard against EA inode refcount underflow in xattr update")
> Signed-off-by: Yang Erkun <yangerkun@...wei.com>

Nice catch! The patch looks good so feel free to add:

Reviewed-by: Baokun Li <libaokun1@...wei.com>

> ---
>  fs/ext4/xattr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 2e02efbddaac..4ed8ddf2a60b 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1037,6 +1037,7 @@ static int ext4_xattr_inode_update_ref(handle_t *handle, struct inode *ea_inode,
>  		ext4_error_inode(ea_inode, __func__, __LINE__, 0,
>  			"EA inode %lu ref wraparound: ref_count=%lld ref_change=%d",
>  			ea_inode->i_ino, ref_count, ref_change);
> +		brelse(iloc.bh);
>  		ret = -EFSCORRUPTED;
>  		goto out;
>  	}