linux-ext4 - Re: [PATCH 01/13] dmflakey: override SCRATCH_DEV in _init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62945fac-eab8-4e42-8f3b-dfdee66a1b15@gmail.com>
Date: Thu, 18 Dec 2025 00:59:50 +0800
From: Anand Jain <anajain.sg@...il.com>
To: Christoph Hellwig <hch@....de>, Zorro Lang <zlang@...nel.org>
Cc: Anand Jain <asj@...nel.org>, Filipe Manana <fdmanana@...e.com>,
 "Darrick J. Wong" <djwong@...nel.org>, fstests@...r.kernel.org,
 linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH 01/13] dmflakey: override SCRATCH_DEV in _init_flakey

 > where to create the custome dm table.

typo
s/custome/custom/

>   _cleanup_flakey()
>   {
>   	# If dmsetup load fails then we need to make sure to do resume here
>   	# otherwise the umount will hang
>   	test -n "$NON_FLAKEY_LOGDEV" && $DMSETUP_PROG resume $FLAKEY_LOGNAME &> /dev/null
>   	test -n "$NON_FLAKEY_RTDEV" && $DMSETUP_PROG resume $FLAKEY_RTNAME &> /dev/null

> -	$DMSETUP_PROG resume flakey-test > /dev/null 2>&1
> +	test -n "$NON_FLAKEY_DEV" && $DMSETUP_PROG resume flakey-test > /dev/null 2>&1

flakey-test target? Appears to be a typo for $FLAKEY_NAME;
I'll send a separate patch fixing the existing bug.

The rest looks good.

Reviewed-by: Anand Jain <asj@...nel.org>

Thanks.