linux-ext4 - Re: [PATCH 02/13] ext4/006: call e2fsck directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9913843-07c1-4750-9545-a5af47f5fbd3@gmail.com>
Date: Thu, 18 Dec 2025 01:01:28 +0800
From: Anand Jain <anajain.sg@...il.com>
To: Christoph Hellwig <hch@....de>, Zorro Lang <zlang@...nel.org>
Cc: Anand Jain <asj@...nel.org>, Filipe Manana <fdmanana@...e.com>,
 "Darrick J. Wong" <djwong@...nel.org>, fstests@...r.kernel.org,
 linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH 02/13] ext4/006: call e2fsck directly

Looks good

Reviewed-by: Anand Jain <asj@...nel.org>

Thanks

On 12/12/25 16:21, Christoph Hellwig wrote:
> _check_scratch_fs takes an optional device name, but no optional
> arguments.  Call e2fsck directly for this extN-specific test instead.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>   tests/ext4/006 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ext4/006 b/tests/ext4/006
> index 2ece22a4bd1e..ab78e79d272d 100755
> --- a/tests/ext4/006
> +++ b/tests/ext4/006
> @@ -44,7 +44,7 @@ repair_scratch() {
>   	res=$?
>   	if [ "${res}" -eq 0 ]; then
>   		echo "++ allegedly fixed, reverify" >> "${FSCK_LOG}"
> -		_check_scratch_fs -n >> "${FSCK_LOG}" 2>&1
> +		e2fsck -n "${SCRATCH_DEV}" >> "${FSCK_LOG}" 2>&1
>   		res=$?
>   	fi
>   	echo "++ fsck returns ${res}" >> "${FSCK_LOG}"