lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201123225402.GB19839@kernel.org> Date: Tue, 24 Nov 2020 00:54:02 +0200 From: Jarkko Sakkinen <jarkko@...nel.org> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: David Howells <dhowells@...hat.com>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, keyrings@...r.kernel.org, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH 052/141] security: keys: Fix fall-through warnings for Clang On Fri, Nov 20, 2020 at 12:32:20PM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > security/keys/process_keys.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c > index 1fe8b934f656..e3d79a7b6db6 100644 > --- a/security/keys/process_keys.c > +++ b/security/keys/process_keys.c > @@ -783,6 +783,7 @@ key_ref_t lookup_user_key(key_serial_t id, unsigned long lflags, > if (need_perm != KEY_AUTHTOKEN_OVERRIDE && > need_perm != KEY_DEFER_PERM_CHECK) > goto invalid_key; > + break; > case 0: > break; > } > -- > 2.27.0 > > Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org> /Jarkko
Powered by blists - more mailing lists