linux-hardening - Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <833549f5-a191-b532-50bf-4ec343c48dd0@molgen.mpg.de>
Date:   Fri, 5 Mar 2021 10:03:58 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     linux-hardening@...r.kernel.org, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
 warnings for Clang

Dear Gustavo,


Thank you for working on that.

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC 
and clang, and it was decided to go with the “clang decision”, and not 
have clang adapt to GCC.

> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
>   drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> index 02b12736ea80..207f6ee3a7f6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> @@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
>   	case ICE_RX_PTYPE_INNER_PROT_UDP:
>   	case ICE_RX_PTYPE_INNER_PROT_SCTP:
>   		skb->ip_summed = CHECKSUM_UNNECESSARY;
> +		break;
>   	default:
>   		break;
>   	}


Kind regards,

Paul