linux-hardening - RE: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB51052F33DA15B71D28E29993FA919@CO1PR11MB5105.namprd11.prod.outlook.com>
Date:   Wed, 10 Mar 2021 00:01:09 +0000
From:   "Brelinski, TonyX" <tonyx.brelinski@...el.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
 warnings for Clang

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Paul Menzel
> Sent: Friday, March 5, 2021 1:04 AM
> To: Gustavo A. R. Silva <gustavoars@...nel.org>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>;
> Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; linux-
> hardening@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
> warnings for Clang
> 
> Dear Gustavo,
> 
> 
> Thank you for working on that.
> 
> Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> > warning by explicitly adding a break statement instead of just letting
> > the code fall through to the next case.
> 
> It would be nice to have a short summary of the discrepancy between GCC
> and clang, and it was decided to go with the “clang decision”, and not have
> clang adapt to GCC.
> 
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > ---
> >   drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> >   1 file changed, 1 insertion(+)

Tested-by: Tony Brelinski <tonyx.brelinski@...el.com> A Contingent Worker at Intel