lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 23 Sep 2021 23:20:03 -0700
From:   Kees Cook <>
To:     Andrew Morton <>
Cc:     Kees Cook <>, Helge Deller <>,
        Qi Zheng <>,
        Vito Caputo <>,
        Josh Poimboeuf <>,
        Jann Horn <>, "Tobin C. Harding" <>,
        Tycho Andersen <>,
        Thomas Gleixner <>,
        Ingo Molnar <>, Borislav Petkov <>,
        "H. Peter Anvin" <>,
        Mark Rutland <>,
        Jens Axboe <>,
        Peter Zijlstra <>,
        Andy Lutomirski <>,
        Lai Jiangshan <>,
        Stefan Metzmacher <>,
        Dave Hansen <>,
        Christian Brauner <>,
        Michal Hocko <>,
        "Eric W. Biederman" <>,
        Randy Dunlap <>,
        Ohhoon Kwon <>,
        YiFei Zhu <>,
        kernel test robot <>,,,,,
Subject: [PATCH 0/3] wchan: Fix ORC support and leaky fallback


This attempts to solve the issues from the discussion
here[1]. Specifically:

1) wchan has been broken under ORC, seen as a failure to stack walk
   resulting in _usually_ a 0 value, since ee9f8fce9964 (v4.14).

2) wchan leaking raw addresses since 152c432b128c (v5.12).

Based on what I can see in the stack walking code, the fix should be
safe. Jann may have more thoughts, but from what I can see, the walker
pins the stack, decodes only a single step, etc.

I'd like Josh's review of Qi Zheng's patch, though. :)

It's also not clear to me what impact this had on kernel/sched/fair.c:
it would have also been seeing 0s, so this may be fixing a bug there too.




Kees Cook (2):
  Revert "proc/wchan: use printk format instead of lookup_symbol_name()"
  leaking_addresses: Always print a trailing newline

Qi Zheng (1):
  x86: Fix get_wchan() to support the ORC unwinder

 arch/x86/kernel/process.c    | 51 +++---------------------------------
 fs/proc/base.c               | 19 ++++++++------
 scripts/ |  3 ++-
 3 files changed, 16 insertions(+), 57 deletions(-)


Powered by blists - more mailing lists