linux-hardening - Re: [PATCH] sparc: Add missing "FORCE" target when using if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Sep 2021 06:38:56 +0200
From:   Nicolas Schier <n.schier@....de>
To:     Kees Cook <keescook@...omium.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Masahiro Yamada <masahiroy@...nel.org>,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] sparc: Add missing "FORCE" target when using if_changed

On Thu, Sep 23, 2021 at 02:54:18PM -0700, Kees Cook wrote:
> Fix observed warning:
> 
>     /builds/linux/arch/sparc/boot/Makefile:35: FORCE prerequisite is missing
> 
> Fixes: e1f86d7b4b2a5213 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: sparclinux@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Acked-by: Nicolas Schier <n.schier@....de>

> ---
> I'm not sure if this should go via sparc or via kbuild. :)
> ---
>  arch/sparc/boot/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/sparc/boot/Makefile b/arch/sparc/boot/Makefile
> index 849236d4eca4..45e5c76d449e 100644
> --- a/arch/sparc/boot/Makefile
> +++ b/arch/sparc/boot/Makefile
> @@ -22,7 +22,7 @@ ifeq ($(CONFIG_SPARC64),y)
>  
>  # Actual linking
>  
> -$(obj)/zImage: $(obj)/image
> +$(obj)/zImage: $(obj)/image FORCE
>  	$(call if_changed,gzip)
>  	@echo '  kernel: $@ is ready'
>  
> @@ -31,7 +31,7 @@ $(obj)/vmlinux.aout: vmlinux FORCE
>  	@echo '  kernel: $@ is ready'
>  else
>  
> -$(obj)/zImage: $(obj)/image
> +$(obj)/zImage: $(obj)/image FORCE
>  	$(call if_changed,strip)
>  	@echo '  kernel: $@ is ready'
>  
> @@ -44,7 +44,7 @@ OBJCOPYFLAGS_image.bin := -S -O binary -R .note -R .comment
>  $(obj)/image.bin: $(obj)/image FORCE
>  	$(call if_changed,objcopy)
>  
> -$(obj)/image.gz: $(obj)/image.bin
> +$(obj)/image.gz: $(obj)/image.bin FORCE
>  	$(call if_changed,gzip)
>  
>  UIMAGE_LOADADDR = $(CONFIG_UBOOT_LOAD_ADDR)
> @@ -56,7 +56,7 @@ quiet_cmd_uimage.o = UIMAGE.O $@
>                       -r -b binary $@ -o $@.o
>  
>  targets += uImage
> -$(obj)/uImage: $(obj)/image.gz
> +$(obj)/uImage: $(obj)/image.gz FORCE
>  	$(call if_changed,uimage)
>  	$(call if_changed,uimage.o)
>  	@echo '  Image $@ is ready'
> -- 
> 2.30.2
>