linux-hardening - Re: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Sep 2021 11:49:45 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     kernel test robot <lkp@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Keerthy <j-keerthy@...com>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Ladislav Michl <ladis@...ux-mips.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        linux-omap@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF

* Kees Cook <keescook@...omium.org> [210828 17:58]:
> When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
> due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
> CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
> 
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Keerthy <j-keerthy@...com>
> Cc: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> Cc: Ladislav Michl <ladis@...ux-mips.org>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: linux-omap@...r.kernel.org
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Kees Cook <keescook@...omium.org>

Sorry for the delay, I just noticed I never replied earlier:

Acked-by: Tony Lindgren <tony@...mide.com>

> ---
>  drivers/clocksource/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..08f8cb944a2a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -24,6 +24,7 @@ config I8253_LOCK
>  
>  config OMAP_DM_TIMER
>  	bool
> +	select TIMER_OF
>  
>  config CLKBLD_I8253
>  	def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
> -- 
> 2.30.2
>