lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 29 Nov 2021 10:45:28 +0000 (UTC)
From:   Kalle Valo <>
To:     Kees Cook <>
Cc:     Jouni Malinen <>, Kees Cook <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Lee Jones <>,
        Allen Pais <>,
        Romain Perier <>,
        Arnd Bergmann <>,
        Vaibhav Gupta <>,
        Cong Wang <>,
        Sebastian Andrzej Siewior <>,,,,
Subject: Re: [PATCH v2] intersil: Use struct_group() for memcpy() region

Kees Cook <> wrote:

> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
> Use struct_group() in struct hfa384x_tx_frame around members
> frame_control, duration_id, addr1, addr2, addr3, and seq_ctrl, so they
> can be referenced together. This will allow memcpy() and sizeof() to
> more easily reason about sizes, improve readability, and avoid future
> warnings about writing beyond the end of frame_control.
> "pahole" shows no size nor member offset changes to struct
> hfa384x_tx_frame. "objdump -d" shows no object code changes.
> Signed-off-by: Kees Cook <>

Patch applied to wireless-drivers-next.git, thanks.

601d2293e27f intersil: Use struct_group() for memcpy() region


Powered by blists - more mailing lists