lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 29 Nov 2021 10:46:25 +0000 (UTC)
From:   Kalle Valo <>
To:     Kees Cook <>
Cc:     Lennert Buytenhek <>,
        Kees Cook <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        wengjianfeng <>,
        Lv Yunlong <>,
        Arnd Bergmann <>,
        Christophe JAILLET <>,
        Allen Pais <>,
        Zheyu Ma <>,,,,
Subject: Re: [PATCH v2] mwl8k: Use named struct for memcpy() region

Kees Cook <> wrote:

> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
> Use named struct in struct mwl8k_cmd_set_key around members key_material,
> tkip_tx_mic_key, and tkip_rx_mic_key so they can be referenced
> together. This will allow memcpy() and sizeof() to more easily reason
> about sizes, improve readability, and avoid future warnings about writing
> beyond the end of key_material.
> "pahole" shows no size nor member offset changes to struct
> mwl8k_cmd_set_key. "objdump -d" shows no object code changes.
> Signed-off-by: Kees Cook <>

Patch applied to wireless-drivers-next.git, thanks.

f01b3774309f mwl8k: Use named struct for memcpy() region


Powered by blists - more mailing lists