linux-hardening - Re: [PATCH -next] sched: Use struct_size() helper in task_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220110111142.7900913e@gandalf.local.home>
Date:   Mon, 10 Jan 2022 11:11:42 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Xiu Jianfeng <xiujianfeng@...wei.com>, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, gustavoars@...nel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH -next] sched: Use struct_size() helper in
 task_numa_group()

On Mon, 10 Jan 2022 17:06:30 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, Jan 07, 2022 at 10:52:12AM +0800, Xiu Jianfeng wrote:
> > Make use of struct_size() helper instead of an open-coded calculation.
> > There is no functional change in this patch.  
> 
> Why ?!? This makes something that was trivial to read into something
> weird.

Please take his last patch (which only modifies the update to size) and
makes it more robust.

  https://lore.kernel.org/all/20220110012354.144394-1-xiujianfeng@huawei.com/

Which is much easier to read.

We should really replace all open coded struct_size() code.

-- Steve