linux-hardening - Re: [PATCH][RESEND] scsi: megaraid: Avoid mismatched storage type sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Jan 2022 17:04:39 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Kees Cook <keescook@...omium.org>,
        Kashyap Desai <kashyap.desai@...adcom.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-hardening@...r.kernel.org,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        megaraidlinux.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RESEND] scsi: megaraid: Avoid mismatched storage type sizes

On Wed, 5 Jan 2022 09:36:33 -0800, Kees Cook wrote:

> Remove needless use of mbox_t, replacing with just struct
> mbox_out. Silences compiler warnings under a -Warray-bounds build:
> 
> drivers/scsi/megaraid.c: In function 'megaraid_probe_one':
> drivers/scsi/megaraid.c:3615:30: error: array subscript 'mbox_t[0]' is partly outside array bounds of 'unsigned char[15]' [-Werror=array-bounds]
>  3615 |         mbox->m_out.xferaddr = (u32)adapter->buf_dma_handle;
>       |         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/megaraid.c:3599:23: note: while referencing 'raw_mbox'
>  3599 |         unsigned char raw_mbox[sizeof(struct mbox_out)];
>       |                       ^~~~~~~~
> 
> [...]

Applied to 5.17/scsi-queue, thanks!

[1/1] scsi: megaraid: Avoid mismatched storage type sizes
      https://git.kernel.org/mkp/scsi/c/315d049ad195

-- 
Martin K. Petersen	Oracle Linux Engineering