lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 25 Apr 2022 14:55:22 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Allen Pais <apais@...ux.microsoft.com>,
        olivier.dautricourt@...lia.com, sr@...x.de, vkoul@...nel.org
Cc:     keescook@...omium.org, linux-hardening@...r.kernel.org,
        ludovic.desroches@...rochip.com, tudor.ambarus@...rochip.com,
        f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, nsaenz@...nel.org,
        paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com,
        gustavo.pimentel@...opsys.com, vireshk@...nel.org,
        andriy.shevchenko@...ux.intel.com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, afaerber@...e.de, mani@...nel.org,
        logang@...tatee.com, sanju.mehta@....com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        agross@...nel.org, bjorn.andersson@...aro.org,
        krzysztof.kozlowski@...aro.org, green.wan@...ive.com,
        orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org,
        wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue



On 4/25/22 10:56, Krzysztof Kozlowski wrote:
> On 19/04/2022 23:16, Allen Pais wrote:
>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
>>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
> 
> Minor nits:
> 
> 1. Don't use "this patch".
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 2. Use subject prefix matching subsystem (git log --oneline)
> 
>>
>> Github: https://github.com/KSPP/linux/issues/94
> 
> 3. No external references to some issue management systems, change-ids
> etc. Lore link could work, but it's not relevant here, I guess.

I think the link to the KSPP issue tracker should stay. If something,
just changing 'Github:' to 'Link:'

The KSPP has been an active _upstream_ project for about 7 years now,
and the issue tracker is publicly available. :) So it's not like a random
link to a random project. This also help us to automatically keep track
of the patches sent out to address a particular issue that we want to
have resolved upstream. So please, keep the link in the changelog text,
it's useful. :)

Thanks
--
Gustavo

Powered by blists - more mailing lists