linux-hardening - Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Apr 2022 16:59:46 -0700
From:   Allen Pais <apais@...ux.microsoft.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     olivier.dautricourt@...lia.com, sr@...x.de, vkoul@...nel.org,
        Kees Cook <keescook@...omium.org>,
        linux-hardening@...r.kernel.org, ludovic.desroches@...rochip.com,
        tudor.ambarus@...rochip.com, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, nsaenz@...nel.org,
        paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com,
        gustavo.pimentel@...opsys.com, vireshk@...nel.org,
        andriy.shevchenko@...ux.intel.com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, afaerber@...e.de, mani@...nel.org,
        logang@...tatee.com, sanju.mehta@....com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        agross@...nel.org, bjorn.andersson@...aro.org,
        krzysztof.kozlowski@...aro.org, green.wan@...ive.com,
        orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, wens@...e.org,
        jernej.skrabec@...il.com, samuel@...lland.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue



> On 25-Apr-2022, at 8:06 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> 
> On Tue, Apr 19, 2022 at 11:17 PM Allen Pais <apais@...ux.microsoft.com> wrote:
> 
>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
>> 
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
>> 
>> Github: https://github.com/KSPP/linux/issues/94
>> 
>> Signed-off-by: Allen Pais <apais@...ux.microsoft.com>
> 
> Booted on:
> 
>> drivers/dma/ste_dma40.c                       | 17 ++++-----
> 
> This DMA-controller with no regressions:
> Tested-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Also looks good so:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

 Thanks for review and testing.

> 
> Yours,
> Linus Walleij