linux-hardening - Re: [PATCH][next] uapi: net/ipv4: Use __DECLARE_FLEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yw+v7yUxS896r2cd@work>
Date:   Wed, 31 Aug 2022 14:01:03 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] uapi: net/ipv4: Use __DECLARE_FLEX_ARRAY() helper

On Wed, Aug 31, 2022 at 11:17:31AM -0700, Kees Cook wrote:
> >  struct ip_msfilter {
> > -	union {
> > -		struct {
> > -			__be32		imsf_multiaddr_aux;
> > -			__be32		imsf_interface_aux;
> > -			__u32		imsf_fmode_aux;
> > -			__u32		imsf_numsrc_aux;
> > +	struct {
> 
> I don't think this internal anonymous struct is needed any more?

yes, aaargh... copy/paste error D:

I'll respin right away.

Thanks!
--
Gustavo