lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Aug 2022 12:01:16 -0700 From: Daniel Latypov <dlatypov@...gle.com> To: Kees Cook <keescook@...omium.org> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>, Vitor Massaru Iha <vitor@...saru.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, kernel test robot <lkp@...el.com>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH] overflow: Split up kunit tests for smaller stack frames On Wed, Aug 31, 2022 at 11:11 AM Kees Cook <keescook@...omium.org> wrote: > > Under some pathological 32-bit configs, the shift overflow KUnit tests > create huge stack frames. Split up the function to avoid this, > separating by rough shift overflow cases. > > Cc: Rasmus Villemoes <linux@...musvillemoes.dk> > Cc: Daniel Latypov <dlatypov@...gle.com> > Cc: Vitor Massaru Iha <vitor@...saru.org> > Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org> > Cc: Nick Desaulniers <ndesaulniers@...gle.com> > Reported-by: kernel test robot <lkp@...el.com> > Link: https://lore.kernel.org/lkml/202208301850.iuv9VwA8-lkp@intel.com > Signed-off-by: Kees Cook <keescook@...omium.org> Acked-by: Daniel Latypov <dlatypov@...gle.com> It's sad that we're forced to do this to eliminate such warnings, but I like this organization a bit better, actually. I wasn't able to reproduce the stack size warnings in the past, so I haven't tried to do so here and can't give Tested-by/Reviewed-by. But I did run the tests and they all still worked for me.
Powered by blists - more mailing lists