lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 7 Sep 2022 16:18:40 -0700
From:   Kees Cook <>
To:     Nick Desaulniers <>
Cc:     Nathan Chancellor <>, Tom Rix <>,
        Andrew Morton <>,
        Vlastimil Babka <>,
        "Steven Rostedt (Google)" <>,
        David Gow <>,
        Yury Norov <>,
        Masami Hiramatsu <>,
        Sander Vanheule <>,,,
        Peter Zijlstra <>,
        Josh Poimboeuf <>,
        Dan Williams <>,
        Isabella Basso <>,
        Eric Dumazet <>,
        Rasmus Villemoes <>,
        Eric Biggers <>,
        Hannes Reinecke <>,
Subject: Re: [PATCH v2 1/3] fortify: Fix __compiletime_strlen() under

On Tue, Sep 06, 2022 at 07:36:46PM -0700, Nick Desaulniers wrote:
> On Fri, Sep 2, 2022 at 1:43 PM Kees Cook <> wrote:
> >
> > Co-developed-by: Nick Desaulniers <>
> That's overly generous of you!

Well, it was a lot of work to track down, and you wrote it up that way,
I just moved things around a little bit. :)

> Anyways, the disassembly LGTM and the bot also came back green.
> Reviewed-by: Nick Desaulniers <>
> Tested-by: Android Treehugger Robot
> Link:

Thank you!

> Another thought, Nikita suggested that you could also compare mode 1 vs mode 3:

Yeah, it could work (I tried this as well), but I think the better
approach is checking index 0.

> That said, since mode 3 returns 0 for "unknown" I'd imagine that
> wouldn't be pretty since it wouldn't be a direct comparison against
> __p_size.

Yeah -- it is a little weird. I might come back to this if we get more
glitches like this in the future.

Kees Cook

Powered by blists - more mailing lists